feat(logs): Move continue scanning into full button#112351
Merged
nsdeschenes merged 9 commits intomasterfrom Apr 7, 2026
Merged
feat(logs): Move continue scanning into full button#112351nsdeschenes merged 9 commits intomasterfrom
nsdeschenes merged 9 commits intomasterfrom
Conversation
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 4 potential issues.
Autofix Details
Bugbot Autofix prepared fixes for all 4 issues found in the latest run.
- ✅ Fixed: Refactored component loses padding-bottom between text elements
- Added paddingBottom='md' prop to Container in EmptyStateText to restore vertical spacing between stacked text elements.
- ✅ Fixed: Text color changes from secondary to primary
- Added variant='muted' prop to Text component in EmptyStateText to restore the original secondary/muted color.
- ✅ Fixed: Uses deprecated style prop instead of align prop
- Replaced deprecated style={{textAlign}} with align prop on Text component following project guidelines.
- ✅ Fixed: Icon variant change affects all empty states app-wide
- Reverted IconSearch variant from 'accent' back to 'muted' in EmptyStateWarning to avoid unintended app-wide visual changes.
Or push these changes by commenting:
@cursor push 0f4f056186
Preview (0f4f056186)
diff --git a/static/app/components/emptyStateWarning.tsx b/static/app/components/emptyStateWarning.tsx
--- a/static/app/components/emptyStateWarning.tsx
+++ b/static/app/components/emptyStateWarning.tsx
@@ -19,13 +19,13 @@
return small ? (
<EmptyMessage className={className}>
<SmallMessage>
- {withIcon && <StyledIconSearch variant="accent" size="lg" />}
+ {withIcon && <StyledIconSearch variant="muted" size="lg" />}
{children}
</SmallMessage>
</EmptyMessage>
) : (
<EmptyStreamWrapper data-test-id="empty-state" className={className}>
- {withIcon && <IconSearch variant="accent" legacySize="54px" />}
+ {withIcon && <IconSearch variant="muted" legacySize="54px" />}
{children}
</EmptyStreamWrapper>
);
diff --git a/static/app/views/explore/tables/tracesTable/styles.tsx b/static/app/views/explore/tables/tracesTable/styles.tsx
--- a/static/app/views/explore/tables/tracesTable/styles.tsx
+++ b/static/app/views/explore/tables/tracesTable/styles.tsx
@@ -133,8 +133,12 @@
textAlign?: CSSProperties['textAlign'];
}) {
return (
- <Container>
- <Text size={size} style={{textAlign}}>
+ <Container paddingBottom="md">
+ <Text
+ size={size}
+ variant="muted"
+ align={textAlign as 'left' | 'center' | 'right' | 'justify'}
+ >
{children}
</Text>
</Container>This Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.
Keep EmptyStateWarning muted by default so other consumers do not inherit logs-specific icon styling. Let the logs table opt into the accent variant explicitly. Refs LOGS-644 Co-Authored-By: GPT-5.4 <noreply@openai.com> Made-with: Cursor
Replace the deprecated inline text alignment style with the supported Text align prop for the traces table empty state. Keep the component typed against the responsive align values exposed by scraps. Co-Authored-By: GPT-5.4 <noreply@openai.com> Made-with: Cursor
Preserve the previous secondary text color for traces table empty states. Without the muted variant, the new Text primitive falls back to the primary token and makes the empty state copy appear bolder. Co-Authored-By: GPT-5.4 <noreply@openai.com> Made-with: Cursor
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 3678ef9. Configure here.
JoshuaKGoldberg
approved these changes
Apr 7, 2026
| ${p => p.textAlign && `text-align: ${p.textAlign}`}; | ||
| `; | ||
| textAlign?: Responsive<'left' | 'center' | 'right' | 'justify'>; | ||
| }) { |
Member
There was a problem hiding this comment.
[Praise] Nice use of the design system 🙂 I like this!
Render `EmptyStateText` as a `div` so loading states can safely include block-level children like `LoadingIndicator` without invalid HTML. Refs LOGS-644 Co-Authored-By: GPT-5.4 <noreply@openai.com> Made-with: Cursor
nsdeschenes
deleted the
nd/LOGS-644/feat-logs-move-continue-scanning-into-full-button
branch
george-sentry
pushed a commit
that referenced
this pull request
Apr 9, 2026
This PR refreshes the continue scanning logs experience to really call out to users that they're able to continue scanning for more data, as the previous setup was a bit harder to read. Refs LOGS-644 --------- Co-authored-by: GPT-5.4 <noreply@openai.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refreshes the continue scanning logs experience to really call out to users that they're able to continue scanning for more data, as the previous setup was a bit harder to read.
Refs LOGS-644
Example:
No Logs Found:
Continue Scanning: